bash if loop produces error

sysmicuser · 02-12-2021, 01:46 AM

Hello,

The snippet of my shell script is as follows:

Code:

mkdir -p /tmp/aa1

if [ "${consider_kinds}" = "all" ] || [ "${consider_kinds}" = "serviceaccounts" ]
then
        echo "Uploading source serviceaccounts"
        cd ${HOME}/sync-cluster/${consider_namespace}/serviceaccounts
        if [ ! -f *.yaml || ! -f *.yml ]
        then
                echo "No yaml manifest file found"
        else
                list_of_files=$(ls -lrt|awk '{print $9}')
                curl --user "${deploy_user}:${deploy_user_password}" -XPUT "https://testcomany.com.au/testrepovirtual/Clustersync/" -H "Content-Type: application/json" -T ${list_of_files}
        fi
fi

if [ "${consider_kinds}" = "all" ] || [ "${consider_kinds}" = "secrets" ]
then
        echo "Uploading source secrets"
        cd ${HOME}/sync-cluster/${consider_namespace}/secrets
        if [ ! -f *.yaml || ! -f *.yml ]
        then
                echo "No yaml manifest file found"
        else
                list_of_files=$(ls -lrt|awk '{print $9}')
                curl --user "${deploy_user}:${deploy_user_password}" -XPUT "https://testcomany.com.au/testrepovirtual/Clustersync/" -H "Content-Type: application/json" -T ${list_of_files}
        fi
fi

if [ "${consider_kinds}" = "all" ] || [ "${consider_kinds}" = "configmaps" ]
then
        echo "Uploading source configmaps"
        cd ${HOME}/sync-cluster/${consider_namespace}/configmaps
        if [ ! -f *.yaml || ! -f *.yml ]
        then
                echo "No yaml manifest file found"
        else
                list_of_files=$(ls -lrt|awk '{print $9}')
                curl --user "${deploy_user}:${deploy_user_password}" -XPUT "https://testcomany.com.au/testrepovirtual/Clustersync/" -H "Content-Type: application/json" -T ${list_of_files}
        fi
fi

if [ "${consider_kinds}" = "all" ] || [ "${consider_kinds}" = "deployments & services" ]
then
        echo "Uploading source deployments"
        cd ${HOME}/sync-cluster/${consider_namespace}/deployments
        if [ ! -f *.yaml || ! -f *.yml ]
        then
                echo "No yaml manifest file found"
        else
                list_of_files=$(ls -lrt|awk '{print $9}')
                curl --user "${deploy_user}:${deploy_user_password}" -XPUT "https://testcomany.com.au/testrepovirtual/Clustersync/" -H "Content-Type: application/json" -T ${list_of_files}
        fi
        cd ${HOME}/sync-cluster/${consider_namespace}/services
        if [ ! -f *.yaml || ! -f *.yml ]
        then
                echo "No yaml manifest file found"
        else
                list_of_files=$(ls -lrt|awk '{print $9}')
                 curl --user "${deploy_user}:${deploy_user_password}" -XPUT "https://testcomany.com.au/testrepovirtual/Clustersync/" -H "Content-Type: application/json" -T ${list_of_files}
        fi
fi

However, I am getting error like below

Code:

./jenkins-part-compose-structure.sh: line 63: [: missing `]'
+ -f '*.yml' ']'
./jenkins-part-compose-structure.sh: line 63: -f: command not found

What I basically want to do is, if there are YAML or YML file(s) are present then get their names so they can be uploaded to the artifactory.

But if the file is not present I don't want the script to fail, it could be legit not to have any particular resource.

What mistake am I making here?

pan64 · 02-12-2021, 04:18 AM

a missing [

Code:

if [ ! -f *.yaml || ! [ -f *.yml ]

I would suggest you to use shellcheck to analyze your script.

berndbausch · 02-12-2021, 10:10 AM

Also, please don't call the if construct a "loop". Nothing loops here. if runs code conditionally.

computersavvy · 02-12-2021, 02:31 PM

shellcheck gives lots of errors and suggestions on that code snippet.

MadeInGermany · 02-12-2021, 05:22 PM

Must be either the deprecated

Code:

if [ ! -f *.yaml -o ! -f *.yml ]

or

Code:

if [ ! -f *.yaml ] || [ ! -f *.yml ]

Still bad, because one token is expected where the glob matches can generate zero or multiple tokens.

A nice fix is a function:

Code:

file_exists() {
  for _i
  do [ -f "$_i" ] && return
  done
  return 1
}

Now it is straight forward

Code:

if ! file_exists *.yaml || ! file_exists *.yml

Last but not least, check the logic!
Doesn't the following make more sense?

Code:

if ! file_exists *.yaml && ! file_exists *.yml

Code:

if ! { file_exists *.yaml || file_exists *.yml; }

Code:

if ! file_exists *.yaml *.yml

computersavvy · 02-12-2021, 07:23 PM

shellcheck said that the test cannot use -f with a glob and suggested using a for loop instead. Simple enough fix.

maybe a -e would work.

Code:

if ! [ -e *.yaml ] || ! [ -e *.yml ]

should work, but I did not try it

The for loop could be

Code:

yamlExists=1
for i in *.yaml ; do yamlExists=0 ; done
if [ "yamlExists" == "1" ]; then
   .....
fi

and a similar loop and test for the *.yml files

MadeInGermany · 02-13-2021, 07:36 AM

The -e does not improve anything.
A for loop is the straight fix (and preferrable over other solutions like "ls -A" ).
And hiding the loop in a universal function is most elegant

JJJCR · 02-13-2021, 08:49 AM

My 2 cents:

Quote:

if ls {*.yaml,*.yml} 1> /dev/null 2>&1; then

echo "files do exist"

else

echo "files do not exist"

fi

shruggy · 02-13-2021, 09:33 AM

@JJJCR. And what if there are *.yaml files, but no *.yml files, or vice versa?

JJJCR · 02-13-2021, 10:22 AM

Quote:

Originally Posted by shruggy

@JJJCR. And what if there are *.yaml files, but no *.yml files, or vice versa?

Yes, that statement is "and" and will return none if one is missing.

edit to this one:

Quote:

GNU nano 4.3 testx.sh

#!/bin/sh

if ls | egrep '\.yaml$|\.yml$' 1> /dev/null 2>&1; then

echo "files do exist"

else

echo "files do not exist"

fi

shruggy · 02-13-2021, 10:28 AM

Code:

if grep -qs . *.yaml *.yml
then echo 'files do exist'
else echo 'files do not exist'
fi

MadeInGermany · 02-13-2021, 10:44 AM

Cannot say that I like that opening of the files.
At least improve it to not require a character:

Code:

if grep -qs '^' *.yaml *.yml

shruggy · 02-13-2021, 11:09 AM

Many grep-like tools (ack, ag, etc.) have the -g option precisely for this, they're not part of the standard Unix toolbox though. I use them all the time on the command line, but not in scripts.

sysmicuser · 02-13-2021, 11:56 PM

Amazing people, Many thanks! Shell check helped a lot.