SlackwareThis Forum is for the discussion of Slackware Linux.
Notices
Welcome to LinuxQuestions.org, a friendly and active Linux Community.
You are currently viewing LQ as a guest. By joining our community you will have the ability to post topics, receive our newsletter, use the advanced search, subscribe to threads and access many other special features. Registration is quick, simple and absolutely free. Join our community today!
Note that registered members see fewer ads, and ContentLink is completely disabled once you log in.
If you have any problems with the registration process or your account login, please contact us. If you need to reset your password, click here.
Having a problem logging in? Please visit this page to clear all LQ-related cookies.
Get a virtual cloud desktop with the Linux distro that you want in less than five minutes with Shells! With over 10 pre-installed distros to choose from, the worry-free installation life is here! Whether you are a digital nomad or just looking for flexibility, Shells can put your Linux machine on the device that you want to use.
Exclusive for LQ members, get up to 45% off per month. Click here for more info.
Distribution: Slackware64-current with "True Multilib" and KDE4Town.
Posts: 9,167
Original Poster
Rep:
Quote:
A One Line Kernel Patch Appears To Solve The Recent Linux + Steam Networking Regression
Written by Michael Larabel in Valve on 22 June 2019 at 12:00 AM EDT.
As a follow-up to the issue reported on Friday regarding the latest Linux kernel releases causing problems for Valve's Steam client, a fix appears pending that with changing around one line of code does appear to address the regression.
Linus Torvalds got involved and pointed out a brand new kernel patch that may solve the issue. That patch was quickly reaffirmed by Linux gamers as well as prominent Valve Linux developer Pierre-Loup A. Griffais.
The patch simply refines the memory limit test within the kernel's tcp_fragment() function. The patch was originally devised by a Google developer and quickly tested as well by an Apple developer, surprisingly.
Hopefully this patch will soon appear in kernel stable releases, "Memory limits might have been exceeded because tcp_sendmsg() only checks limits at full skb (64KB) boundaries. Therefore, we need to make sure tcp_fragment() wont punish applications that might have setup very low SO_SNDBUF values."
It was pointed out by Pierre of Valve that Linux desktop distributions should have caught onto such a regression:
Quote:
Pierre-Loup Griffais @Plagman2
The regression highlights the fact that there are currently no true desktop distributions. A desktop product would have seen the server-centric security fix get queued, tested and found the fact that it breaks Steam, and held it off for the two days it needed to get fixed.
59
6:37 PM - Jun 21, 2019
I really wish there was a better way of going about things. I was going to review the changelog to see if there was anything significant in this batch, or whether I could safely skip this release, but then I realised it would actually take far more effort than just building the damn thing. On the other hand, building a new kernel every 3 or so days is just madness.
I suppose there's always the "Don't update unless some big issue hits the headlines" approach, but I've never been a fan of that one.
tcp_fragment() might be called for skbs in the write queue.
Memory limits might have been exceeded because tcp_sendmsg() only
checks limits at full skb (64KB) boundaries.
Therefore, we need to make sure tcp_fragment() wont punish applications
that might have setup very low SO_SNDBUF values.
Fixes: f070ef2ac667 ("tcp: tcp_fragment() should apply sane memory limits")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Christoph Paasch <cpaasch@apple.com>
Tested-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Last edited by cwizardone; 06-22-2019 at 09:24 PM.
FYI, I'm installing the 64-bit 4.4.182 huge kernel (via the 14.2 Slackware update packages) on all of my 64-bit 14.1 systems, including this laptop, and so far no problems at all.
Will report any issues, but it looks like 4.4.x continues to be a viable way forward for 14.1.
LinuxQuestions.org is looking for people interested in writing
Editorials, Articles, Reviews, and more. If you'd like to contribute
content, let us know.